[ISSUE #10832] fix(remoting): reject malformed command frames - #10842
Open
yuluo-yx wants to merge 1 commit into
Open
[ISSUE #10832] fix(remoting): reject malformed command frames#10842yuluo-yx wants to merge 1 commit into
yuluo-yx wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10842 +/- ##
=============================================
- Coverage 48.37% 48.31% -0.06%
+ Complexity 13555 13537 -18
=============================================
Files 1380 1380
Lines 101165 101170 +5
Branches 13127 13129 +2
=============================================
- Hits 48940 48884 -56
- Misses 46250 46300 +50
- Partials 5975 5986 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RockteMQ-AI
approved these changes
Aug 8, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Good input validation for RemotingCommand deserialization — rejecting negative opaque, out-of-range version, and negative flag values prevents malformed frames from being processed silently. The NumberFormatException handling for the optional flag field is correct.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
Reject short command frames and unknown serialization types with
RemotingCommandExceptioninstead of unchecked exceptions.How Did You Test This Change?
mise x java@temurin-17 -- mvn -pl remoting -am -Dtest=RemotingCommandTest -Dsurefire.failIfNoSpecifiedTests=false test