RANGER-5751 : service-config UI show duplicate entries for trino plugin - #1170
Open
dhavaljrajpara wants to merge 1 commit into
Open
RANGER-5751 : service-config UI show duplicate entries for trino plugin#1170dhavaljrajpara wants to merge 1 commit into
dhavaljrajpara wants to merge 1 commit into
Conversation
dhavaljrajpara
requested review from
fimugdha,
mneethiraj and
pradeepagrawal8184
August 21, 2026 11:54
mneethiraj
reviewed
Aug 21, 2026
| { "itemId": 7, "name": "ranger.plugin.super.groups", "type": "string", "defaultValue": "trino", "label": "Superuser groups", "description": "Users in superuser groups will have full access to all resources in this Trino instance" }, | ||
| { "itemId": 8, "name": "service.admin.users", "type": "string", "defaultValue": "trino", "label": "Service admin users", "description": "Service admin users can create policies for any resource in this Trino instance" }, | ||
| { "itemId": 9, "name": "service.admin.groups", "type": "string", "defaultValue": "trino", "label": "Service admin usergroups", "description": "Users in service admin usergroups can create policies for any resource in this Trino instance" } | ||
| { "itemId": 5, "name": "ranger.plugin.audit.filters", "type": "string", "defaultValue": "[{'accessResult':'DENIED','isAudited':true},{'isAudited':false,'resources':{'queryid':{'values':['*']}},'accessTypes':['execute']},{'isAudited':false,'resources':{'trinouser':{'values':['{USER}']}},'accessTypes':['impersonate']}]" } |
Contributor
There was a problem hiding this comment.
@dhavaljrajpara - this fix will not address Ranger deployments that already have earlier Trino service-def. In addition to this fix in Trino service-def, I suggest UI updates to not duplicate configurations included in the service-def.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue Summary
Duplicate service configurations (Superusers/Service Admin) in Trino service definition.
Problem Description
In the Trino service definition, duplicate entries are currently appearing for the following service configuration options on the UI:
Root Cause
The Trino service definition JSON already contains these management properties explicitly. However, following RANGER-3643, these properties were also added dynamically on the frontend across all service definitions. As a result, Trino inherits both sets of definitions, rendering duplicate inputs in the service creation/edit UI.
Due to this duplication, submitting the service configuration form constructs a malformed JSON payload, resulting in invalid/incorrect values being stored in the database and causing service creation to fail.
Expected Behavior
How was this patch tested?
Superusers,Superuser groups,Service admin users, andService admin usergroupsonly once.