Support optional parameters argument for tuple sketch aggregations in the multi-stage engine - #19312
Open
davecromberge wants to merge 1 commit into
Conversation
…age engine IntegerSumTupleSketch aggregations accept an optional parameters operand (e.g. nominalEntries) in the single-stage engine, but were registered with OperandTypes.BINARY, so the multi-stage engine rejected the parameterized form at query validation. Register them with the same 1-or-2 operand signature as the CPC sketch functions, and cover the parameterized form in TupleSketchTest.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19312 +/- ##
=========================================
Coverage 67.18% 67.18%
Complexity 1424 1424
=========================================
Files 3462 3462
Lines 220361 220365 +4
Branches 35147 35147
=========================================
+ Hits 148045 148056 +11
+ Misses 60506 60502 -4
+ Partials 11810 11807 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The IntegerSumTupleSketch aggregation functions (
distinctCountTupleSketch,distinctCountRawIntegerSumTupleSketch,sumValuesIntegerSumTupleSketch,avgValueIntegerSumTupleSketch) accept an optional second parameters argument (e.g.nominalEntries) in the single-stage engine, but are registered inAggregationFunctionTypewithOperandTypes.BINARY(exactly one operand). The multi-stage engine therefore rejects the parameterized form at query validation:even though the identical query runs on the single-stage engine.
Fix
Register the four tuple-sketch aggregations with the same 1-or-2 operand signature (
OperandTypes.family(List.of(ANY, ANY), i -> i == 1)) already used by the CPC sketch functions, so the optional parameters operand is accepted. This is a planning-only change; execution, return types, and serialization are unchanged.Testing
TupleSketchTestnow exercises the 2-argument (parameterized) form across both query engines.