[core][flink] Refactor partition time resolution using PartitionTimeResolver - #9008
Open
juntaozhang wants to merge 15 commits into
Open
[core][flink] Refactor partition time resolution using PartitionTimeResolver#9008juntaozhang wants to merge 15 commits into
juntaozhang wants to merge 15 commits into
Conversation
Contributor
|
The new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
this PR follow #8185, refactors partition time resolution as the title suggests.
Tests
Benchmark:
PartitionTimeResolvervsPartitionTimeExtractorEnv:
50,000warmup iterations +200,000iterations for each task.Each result is reported as average time per operation.
Initmeans constructing the object.Ratio < 1meansPartitionTimeResolveris faster;Ratio > 1means slower.Parse to date
PartitionTimeExtractor.extractPartitionTimeResolver$dt/yyyyMM-dd$y$m$d/yyyyMMdd$dt $hr/yyyyMMdd HH$a-$b-$c T $hour:$minute:00/yyyy-MM-dd 'T' HH:mm:ssEach loop construct the object and
parseto datePartitionTimeExtractor.extractPartitionTimeResolver$dt/yyyyMM-dd$y$m$d/yyyyMMdd$dt $hr/yyyyMMdd HH$a-$b-$c T $hour:$minute:00/yyyy-MM-dd 'T' HH:mm:ssResolve date to partition values
ChainTableUtils.calPartValuesPartitionTimeResolver$dt/yyyyMM-dd$y$m$d/yyyyMMdd$dt $hr/yyyyMMdd HH$a-$b-$c T $hour:$minute:00/yyyy-MM-dd 'T' HH:mm:ssEach loop construct the object and
resolvedate to partition valuesChainTableUtils.calPartValuesPartitionTimeResolver$dt/yyyyMM-dd$y$m$d/yyyyMMdd$dt $hr/yyyyMMdd HH$a-$b-$c T $hour:$minute:00/yyyy-MM-dd 'T' HH:mm:ssSummary
PartitionTimeResolveris significantly faster, often 2–20x overPartitionTimeExtractor.PartitionTimeResolveris heavier because it validates and maps pattern ↔ formatter upfront.PartitionTimeExtractorconstructs almost instantly because its do nothing.PartitionTimeResolver. Only complex patterns become slower overall due to recursive matching in construction.