HDDS-16257. Avoid the flatten-copy in OmMetadataManagerImpl.getExpiredOpenKeys' hsync branch - #11116
Open
shuan1026 wants to merge 2 commits into
Open
HDDS-16257. Avoid the flatten-copy in OmMetadataManagerImpl.getExpiredOpenKeys' hsync branch#11116shuan1026 wants to merge 2 commits into
shuan1026 wants to merge 2 commits into
Conversation
…dOpenKeys' hsync branch
sarvekshayr
reviewed
Aug 26, 2026
sarvekshayr
left a comment
Contributor
There was a problem hiding this comment.
Thanks @shuan1026 for working on this.
Minor nits not related to your changes.
| @@ -1510,9 +1504,10 @@ public ExpiredOpenKeys getExpiredOpenKeys(Duration expireThreshold, | |||
| .setKeyName(openKeyInfo.getKeyName()) | |||
| .setDataSize(info.getDataSize()); | |||
| java.util.Optional.ofNullable(info.getLatestVersionLocations()) | |||
Contributor
There was a problem hiding this comment.
nit: Add the import for Optional at the top.
Suggested change
| java.util.Optional.ofNullable(info.getLatestVersionLocations()) | |
| Optional.ofNullable(info.getLatestVersionLocations()) |
sravani-revuri
left a comment
Contributor
There was a problem hiding this comment.
agree with @sarvekshayr on the import. Otherwise LGTM.
Contributor
Author
|
Done, thanks @sarvekshayr @sravani-revuri for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OmMetadataManagerImpl.getExpiredOpenKeys's hsync-commit branch calledOmKeyLocationInfoGroup.createLocationList()on the key's latest version group just to stream it once while building the commitKeyArgsprotobuf, allocating a throwaway flattenedListper matched hsync key.This PR swaps the method reference for the zero-copy
getLocationLists()accessor and inserts aflatMap(List::stream)to keep the rest of the chain (.map(getProtobuf).forEach(addKeyLocations)) unchanged.Additionally, a throwaway (not committed) JUnit micro-benchmark measured per-
KeyArgs-construction thread allocation for both implementations (JDK 21.0.12, 50,000-iteration warmup then 500,000 measured iterations per shape, outputKeyArgsprotobufs asserted equal,volatilesink to block JIT elimination):What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16257
How was this patch tested?
TestOpenKeyCleanupService#testCommitExpiredHsyncKeysTestOpenKeyCleanupService#testCleanupExpiredOpenKeysTestOpenKeyCleanupService#testIgnoreExpiredRecoverhsyncKeys