HDDS-16256. Avoid the per-group list copy in OMKeyRequest.filterOutBlocksStillInUse - #11115
Open
shuan1026 wants to merge 1 commit into
Open
HDDS-16256. Avoid the per-group list copy in OMKeyRequest.filterOutBlocksStillInUse#11115shuan1026 wants to merge 1 commit into
shuan1026 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OMKeyRequest.filterOutBlocksStillInUsecalledOmKeyLocationInfoGroup.createLocationList()on every version group of the reference key just to build aMap<ContainerBlockID, OmKeyLocationInfo>lookup table, allocating a throwaway flattenedListper group that is immediately re-streamed and discarded.This PR replaces the
flatMap(createLocationList().stream())chain with nested stream flattening overgetLocationLists(), removing the per-group list allocation while preservingCollectors.toMapduplicate-key semantics.Additionally, a throwaway (not committed) JUnit micro-benchmark measured per-lookup-map-construction thread allocation for both implementations (JDK21.0.12, 50,000-iteration warmup then 500,000 measured iterations per shape, output maps asserted equal,
volatilesink to block JIT elimination):What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16256
How was this patch tested?
TestOMKeyCommitRequest#testValidateAndUpdateCacheOnOverwriteTestOMKeyCommitRequest#testValidateAndUpdateCacheOnOverwriteWithUncommittedBlocks