HDDS-16279. Cache replica index map in Pipeline - #11114
Open
rich7420 wants to merge 1 commit into
Open
Conversation
getReplicaIndexes() re-derived the {node -> replicaIndex} map (stream + toMap
+ boxing) on every call, on the per-block-read command-build path. Memoize it
in a lazy volatile field, returned as an unmodifiable view. reportDatanode()
can change the node set, so it drops the cached view. Behavior unchanged.
rich7420
marked this pull request as draft
August 25, 2026 15:36
rich7420
marked this pull request as ready for review
August 26, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pipeline.getReplicaIndexes()re-derived the{node -> replicaIndex}map (stream +toMap+ boxing) on every call, on the per-block-read command-build path. It is now memoized in a lazyvolatilefield and returned as an unmodifiable view.reportDatanode()is the only method that can change the node set, so it drops the cached view. Same contents (all callers only read the map), so behavior is unchanged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16279
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32860599887
JMH (out of tree, isolating
getReplicaIndexes()), JDK 21: