HDDS-16278. Reuse DecimalFormat in SCMNodeManager statistics - #11113
Open
rich7420 wants to merge 1 commit into
Open
HDDS-16278. Reuse DecimalFormat in SCMNodeManager statistics#11113rich7420 wants to merge 1 commit into
rich7420 wants to merge 1 commit into
Conversation
convertUnit, calculateStoragePercentage and nodeUsageStatistics built a DecimalFormat per datanode inside the node-stats/JMX loops. Cache one per thread (ThreadLocal, since DecimalFormat is not thread-safe) for each of the two patterns (#0.0, #0.00). Same pattern and rounding mode, so the formatted output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCMNodeManagerbuilt aDecimalFormatper datanode inside the node-stats/JMX loops (convertUnit,calculateStoragePercentage,nodeUsageStatistics). This caches one per thread (ThreadLocal, sinceDecimalFormatis not thread-safe) for each of the two patterns (#0.0,#0.00). Same pattern and rounding mode, so the formatted output is unchanged.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16278
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32855331989
JMH (out of tree, isolating the formatter acquisition), JDK 21:
#0.0#0.00