Skip to content

HDDS-16253. Fix getPipelines() in Recon always returning an empty pipeline list #11090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuan1026 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

HDDS-16253. Fix getPipelines() in Recon always returning an empty pipeline list #11090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...c/main/java/org/apache/hadoop/ozone/recon/spi/impl/ReconContainerMetadataManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,10 +514,10 @@ private List<Pipeline> getPipelines(ContainerKeyPrefix containerKeyPrefix)
}
List<Pipeline> pipelines = new ArrayList<>();
if (null != omKeyInfo) {
omKeyInfo.getKeyLocationVersions().stream().map(
omKeyInfo.getKeyLocationVersions().forEach(
omKeyLocationInfoGroup ->
omKeyLocationInfoGroup.getLocationList()
.stream().map(omKeyLocationInfo -> pipelines.add(
omKeyLocationInfoGroup.getLocationList().forEach(

@devmadhuu devmadhuu Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better, if we should de-duplicate the pipeline list here itself rather at the caller.

@devmadhuu devmadhuu Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
omKeyLocationInfoGroup.getLocationList().forEach(
pipelines.addAll(
omKeyInfo.getKeyLocationVersions().stream()
.flatMap(g -> g.getLocationList().stream())
.map(OmKeyLocationInfo::getPipeline)
.collect(Collectors.toList()));

omKeyLocationInfo -> pipelines.add(

@devmadhuu devmadhuu Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the following assertions in our existing test here

ContainerMetadata cm = containerMap.get(containerId);                                                                                                                                                    
  assertNotNull(cm.getPipelines());                                                                                                                                                                        
  assertFalse(cm.getPipelines().isEmpty(),                                                                                                                                                                 
      "Pipelines list should be populated from OmKeyLocationInfo");                                                                                                                                        
  // If test data has known pipeline count, assert it exactly.

omKeyLocationInfo.getPipeline())));
}
return pipelines;
Expand Down