Route SSO configuration through tasks and preserve legacy cleanup#43
Merged
Conversation
miki3421
marked this pull request as ready for review
July 12, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ops config sso disablewith targeted JSON Patch operationsenv,envFrom, volumes, volume mounts, and annotations on the admin-api StatefulSetSSO_*configuration keysops config ssocommandops -config ssoimplementation only as a documented legacy compatibility surfaceRoot cause
The previous disable implementation sent
envFrom: nullfor the selected admin-api container. Kubernetes therefore removed the completeenvFromlist, including ConfigMap and Secret references installed by other components. The enable path also replaced the complete list.In addition,
main.gointerceptedops config ssobefore normal task dispatch. This made SSO the onlyops configsubtree whose release-specific orchestration lived in the CLI and required a new CLI release for every change.The new implementation reads the StatefulSet and adds or removes only exact, prefix-free references to the ConfigMap and Secret managed by
ops config sso. JSON Patchtestoperations guard removals so a concurrent list change cannot make the command remove the wrong entry.The special public dispatcher is removed. A companion pull request in
apache/openserverless-tasksupplies the realconfig/ssotask on branch0.9.1. The embedded form remains available only throughops -config ssofor backward compatibility.Behavior
--ignore-not-found--no-rolloutskips rollout waiting and does not issue a restartenvFromreferences starts the required Kubernetes rollout without adding a redundant restart annotationValidation
go test -count=1 ./...go test -race ./configgo vet ./configgo build ./cmd/opsgit diff --checktesting/tests/11-sso-mock.sh kindwith companion task PR (rc=0)Tests cover unrelated direct environment variables, unrelated ConfigMap and Secret
envFromreferences, unrelated volumes and mounts, repeated disable, and the completeenable -> disable -> enablecycle.