Fix SSO device-flow workspace selection#42
Merged
Conversation
Contributor
Author
|
Companion task PR targeting the required |
Contributor
Author
|
Release version is prepared inside this PR as |
sciabarracom
approved these changes
Jul 12, 2026
sciabarracom
marked this pull request as ready for review
July 12, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPS_USERandOPSDEV_USERNAMEvalues reloaded fromconfig.jsonOPSDEV_USERNAME=as documented byops -configRoot cause
setAllConfigEnvVars()reloads persisted IDE values beforeLoginCmd()runs. The oldOPSDEV_USERNAME=nuvolarisfallback was therefore passed asnamespaceto/system/api/v1/auth/oidc/device/start, even when the current device login did not request a workspace. A successful Keycloak login formichelemwas then correctly rejected by admin-api because it did not match the stale requested namespace.The admin-api namespace mismatch check is unchanged. This PR only distinguishes an explicit workspace request from persisted local fallback state.
Validation
go test ./...go test ./auth ./configtask itest T=config F="--formatter tap"(13/13)OPS_USER/OPSDEV_USERNAMEare absent from device start and poll payloadsgit diff --checkFollow-up
The companion
apache/openserverless-task:0.9.1PR updatesops ide loginso an explicit<username>is forwarded positionally while the implicit device flow forwards no workspace. A new dev release must be tagged from Apachemainonly after these PRs are reviewed and merged.