testing/ostest: multiuser coverage for supplementary groups and setresuid - #3714
Open
Abhishekmishra2808 wants to merge 2 commits into
Open
testing/ostest: multiuser coverage for supplementary groups and setresuid#3714Abhishekmishra2808 wants to merge 2 commits into
Abhishekmishra2808 wants to merge 2 commits into
Conversation
acassis
requested review from
cederom,
linguini1,
raiden00pl,
xiaoxiang781216 and
yf13
August 10, 2026 19:13
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 12, 2026 06:40
9b7be97 to
6c7b378
Compare
github-actions
Bot
added
Size: M
Area: Testing
and removed
Area: File System
Size: XL
labels
xiaoxiang781216
previously approved these changes
Aug 12, 2026
Contributor
|
@Abhishekmishra2808 please fix ci warning and pr title/description |
Add supplementary-group, setresuid/setresgid ordering, and saved set-UID/GID child tests for the POSIX credential APIs. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 12, 2026 07:05
6c7b378 to
4cf5292
Compare
Abhishekmishra2808
changed the title
|
|
||
| # if defined(CONFIG_NSH_READLINE) && \ | ||
| (defined(CONFIG_READLINE_TABCOMPLETION) || defined(CONFIG_READLINE_EDIT)) | ||
| readline_prompt(nsh_prompt()); |
Contributor
There was a problem hiding this comment.
how about readline isn't enabled
Contributor
Author
There was a problem hiding this comment.
updated the code, please take a look
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 12, 2026 17:38
5c04648 to
fbe1485
Compare
When NSH_PROMPT_STRING_ROOT/USER are empty, keep NSH_PROMPT_STRING at boot (for example, "nsh> ") so CI/NTFC boot detection still works. After login, su, or telnet login, replace the last '>' with '#' (euid 0) or '$' (non-zero euid) and ensure a trailing space. Refresh readline after console/telnet login when line editing is enabled. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 12, 2026 18:52
fbe1485 to
b07c609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
This change only extends testing/ostest/multiuser.c to exercise the new kernel credential APIs. It adds coverage for supplementary groups, setresuid/setresgid drop ordering, getresuid/setreuid, and saved set-UID/GID behavior in a child task. Builds without
CONFIG_SCHED_USER_IDENTITYare unchanged.Testing