NIFI-16100 Allow non-sensitive connector properties to reference Secrets Manager values - #11425
Open
pvillard31 wants to merge 1 commit into
Open
NIFI-16100 Allow non-sensitive connector properties to reference Secrets Manager values#11425pvillard31 wants to merge 1 commit into
pvillard31 wants to merge 1 commit into
Conversation
…ets Manager values
pvillard31
force-pushed
the
NIFI-16100-connector-unrestricted-secrets
branch
from
July 13, 2026 18:29
912df66 to
89e16a3
Compare
exceptionfactory
requested changes
Jul 25, 2026
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks for implementing this new feature @pvillard31. The changes look good, I noted a couple minor recommendations on the test classes. If you can address those and rebase the branch, this should be ready to go.
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class TestParameterProviderSecretProvider { |
Contributor
There was a problem hiding this comment.
The public modifiers can be removed
Comment on lines
+38
to
+66
| @Test | ||
| public void testTagValueTrueLowercaseIsUnrestricted() { | ||
| assertEquals(PropertyProtectionType.UNRESTRICTED, classify(TAG_NAME, List.of(new ParameterTag(TAG_NAME, "true")))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTagValueTrueTitlecaseIsUnrestricted() { | ||
| assertEquals(PropertyProtectionType.UNRESTRICTED, classify(TAG_NAME, List.of(new ParameterTag(TAG_NAME, "True")))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTagValueTrueUppercaseIsUnrestricted() { | ||
| assertEquals(PropertyProtectionType.UNRESTRICTED, classify(TAG_NAME, List.of(new ParameterTag(TAG_NAME, "TRUE")))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTagValueFalseIsRestricted() { | ||
| assertEquals(PropertyProtectionType.RESTRICTED, classify(TAG_NAME, List.of(new ParameterTag(TAG_NAME, "false")))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTagValueNullIsRestricted() { | ||
| assertEquals(PropertyProtectionType.RESTRICTED, classify(TAG_NAME, List.of(new ParameterTag(TAG_NAME, null)))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTagKeyMismatchIsRestricted() { | ||
| assertEquals(PropertyProtectionType.RESTRICTED, classify(TAG_NAME, List.of(new ParameterTag("other-tag", "true")))); | ||
| } |
Contributor
There was a problem hiding this comment.
It looks like a number of these methods could be collapsed into a ParameterizedTest
| connectorNode.transitionStateForUpdating(); | ||
| connectorNode.prepareForUpdate(); | ||
| final Map<String, ConnectorValueReference> propertyValues = new HashMap<>(); | ||
| propertyValues.put("StringProp", new SecretReference("pid", "My Provider", "my-secret", "My Provider.my-secret")); |
Contributor
There was a problem hiding this comment.
The SecretReference and some other variables can be declared once and reused across several test methods.
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Following up on this pull request, if the feedback can be addressed, and the branch rebased, it should be close to completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16100 Allow non-sensitive connector properties to reference Secrets Manager values
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation