NIFI-13125 - Flow Version Diff View - #10473
Conversation
010fc08 to
d1ff571
Compare
scottyaslan
left a comment
There was a problem hiding this comment.
Thanks for this contribution. I have left some comments. I am happy to review and help iterate here and continue to improve the UX for this feature.
|
Thanks for all the feedback @scottyaslan - highly appreciated! I have (hopefully) made the changes you had in mind. The only thing that is not ok is the timestamp in the dropdown lists when selecting versions. Will figure it out tomorrow. It looks so much better now, thanks for all of the review comments!
|
|
Would love to see this feature! |
|
Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label and automated closure does not indicate a judgement of the PR, just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale label. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
|
Closing. See #11474. |




Summary
NIFI-13125 - Flow Version Diff View
I used #9109 as a starting point and coded something similar for NiFi 2.x. Definitely not a UI expert so my approach may not be the best one. Happy to collaborate with someone more experienced on the UI side.
This feature is particularly useful when a user sees that a versioned process group can be updated to a new version and the user would like to see what are the differences with the current version before upgrading the process group.
Access to the view is made available when listing versions for a versioned process group:
Clicking on the diff icon for the desired version will show the diff between the current version and the selected version
Versions can be selected via the dropdown lists:
Filtering is also possible to filter the content of the table, and the columns can also be sorted alphabetically.
The current feature does not allow comparison across branches but that could be considered as a follow-up improvement if the community sees value into it (I'm not sure I picture a use case where it would be very useful).
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation