Conversation
There was a problem hiding this comment.
Pull request overview
Updates POM XML namespace emission in PomWriter to use the canonical Maven 4.0.0 namespace URI, ensuring generated POMs declare the standard namespace.
Changes:
- Hardcode the POM XML namespace to
http://maven.apache.org/POM/4.0.0. - Update the
schemaLocationattribute’s namespace portion to matchhttp://maven.apache.org/POM/4.0.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| root.setAttribute( | ||
| "schemaLocation", | ||
| "http://maven.apache.org/POM/" + modelVersion + " http://maven.apache.org/maven-v" | ||
| "http://maven.apache.org/POM/4.0.0" + " http://maven.apache.org/maven-v" |
There was a problem hiding this comment.
This concatenation joins two string literals (".../4.0.0" + " http://...") which is harder to read than a single literal. Collapsing it into one string (or building it from constants) would improve readability.
| "http://maven.apache.org/POM/4.0.0" + " http://maven.apache.org/maven-v" | |
| "http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v" |
|
FYI CI looks broken: Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.43.0:check (default) on project maven-shade-plugin: Execution default of goal com.diffplug.spotless:spotless-maven-plugin:2.43.0:check failed: An API incompatibility was encountered while executing com.diffplug.spotless:spotless-maven-plugin:2.43.0:check: java.lang.NoSuchMethodError: 'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()' |
|
@elharo did you rebase your branch with the latest master version? |
|
done |
No description provided.