Skip to content

ci(rust): don't fail when a DAG scope matches no tests #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hubcio merged 3 commits into from
Aug 21, 2026
Merged

ci(rust): don't fail when a DAG scope matches no tests #3943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2efcf09
ci(rust): don't fail when a DAG scope matches no tests
chengxilo Aug 21, 2026
eea5cab
Merge branch 'master' into ci/dag-do-not-fail-empty
chengxilo Aug 21, 2026
5310f54
Merge branch 'master' into ci/dag-do-not-fail-empty
hubcio Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/rust/pre-merge/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,12 @@ runs:
test_start=$(date +%s)
if command -v cargo-nextest &> /dev/null; then
if [[ -n "$NEXTEST_FILTER" ]]; then
cargo nextest run --locked --no-fail-fast --profile ci $PARTITION_FLAG $PACKAGE_FLAGS -E "$NEXTEST_FILTER"
# Every test target in the `bdd` crate is `required-features =
# ["bdd"]`, so the `cargo test --no-run` above builds no binaries
# for it. A PR touching only that crate then produces a valid
# filter that matches zero tests, and nextest's default
# `--no-tests=fail` turns that into exit 4 on a green PR.
cargo nextest run --locked --no-fail-fast --no-tests=warn --profile ci $PARTITION_FLAG $PACKAGE_FLAGS -E "$NEXTEST_FILTER"
else
cargo nextest run --locked --no-fail-fast --profile ci $PARTITION_FLAG
fi
Expand Down
Loading