feat(sdk): support per-request timeout to TCP/QUIC/WebSocket clients#3429
Open
chengxilo wants to merge 10 commits into
Open
feat(sdk): support per-request timeout to TCP/QUIC/WebSocket clients#3429chengxilo wants to merge 10 commits into
chengxilo wants to merge 10 commits into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3429 +/- ##
============================================
- Coverage 74.27% 72.26% -2.02%
Complexity 937 937
============================================
Files 1259 1259
Lines 125969 121376 -4593
Branches 101644 97093 -4551
============================================
- Hits 93558 87707 -5851
- Misses 29396 30385 +989
- Partials 3015 3284 +269
🚀 New features to boost your workflow:
|
hubcio
requested changes
Jun 9, 2026
8b9a947 to
005b84e
Compare
Contributor
Author
|
/ready |
3c5bfab to
b08a9a2
Compare
Contributor
Author
|
/author |
Contributor
Author
|
After merging there is something need to be changed. |
Contributor
Author
|
/ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #3419
Rationale
Clients had no deadline on individual request, so a stalled server could block a caller forever.
What changed?
send_rawwould be blocked forever if server doesn't response. I added a request_timeout field (IggyDuration, default 300s) to TcpClientConfig, QuicClientConfig, and WebSocketClientConfig. Each client'ssend_rawnow wraps its I/O intokio::time::timeoutLocal Execution
AI Usage
Change Log
By default, Iggy Rust SDK would have a 30s timeout for each request.