fix(transform): support hour transform for nanosecond arrays - #3026
Open
mattfaltyn wants to merge 1 commit into
Open
fix(transform): support hour transform for nanosecond arrays#3026mattfaltyn wants to merge 1 commit into
mattfaltyn wants to merge 1 commit into
Conversation
mattfaltyn
marked this pull request as ready for review
August 19, 2026 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
hourtransform using the existing nanosecond conversion helper.timestamp_nsandtimestamptz_nsarrays, including a pre-epoch value.Are these changes tested?
cargo test -p iceberg transform::temporal::test::test_transform_hours --libmake checkmake unit-testICEBERG_TEST_HMS_ENDPOINT=127.0.0.1:9083 cargo nextest run --all-targets --all-features --workspace --no-fail-fast --test-threads 1(2,067 passed, 0 skipped)AI Disclosure
Codex assisted with repository inspection, duplicate issue/PR searches, test scaffolding, implementation, validation, and drafting this PR. I reviewed the complete diff and verified the behavior and tests end to end.