feature(encryption): [17/N] Enable encrypted writes - #3018
Open
xanderbailey wants to merge 3 commits into
Open
Conversation
xanderbailey
force-pushed
the
xb/enable_encrypted_writes
branch
2 times, most recently
from
August 18, 2026 13:41
3456935 to
c38af67
Compare
xanderbailey
force-pushed
the
xb/enable_encrypted_writes
branch
from
August 18, 2026 13:50
c38af67 to
271c4db
Compare
blackmwk
reviewed
Aug 19, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @xanderbailey for this pr! Generally LGTM, just one comment about integration test.
| #[case::sql_catalog(CatalogKind::Sql)] | ||
| #[case::memory_catalog(CatalogKind::Memory)] | ||
| #[tokio::test] | ||
| async fn test_catalog_purge_encrypted_table(#[case] kind: CatalogKind) -> Result<()> { |
Contributor
There was a problem hiding this comment.
We have several methods for updating table, I'm thinking maybe we should make encrypted or not a test case param?
Contributor
Author
There was a problem hiding this comment.
Gave it a go 85bc744 for the purge test, were there others you think I needed to include in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Since merging #2701 we can now write encrypted parquet files which means we now fully support read and write paths. The last step is to remove the error on the commit path to allow users to actually write encrypted tables.
Are these changes tested?
I've added roundtrip tests for datafusion in a new slt test and purge table catalog tests can now be added since we can commit to an encrypted table.
AI Disclosure