Skip to content

Rename RestContext to RestClient - #2994

Merged
CTTY merged 2 commits into
apache:mainfrom
DerGut:rest-client
Aug 13, 2026
Merged

Rename RestContext to RestClient#2994
CTTY merged 2 commits into
apache:mainfrom
DerGut:rest-client

Conversation

@DerGut

@DerGut DerGut commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Following from #2920 (comment)

This is a rename to resolve a naming conflict between the previous RestContext and SessionContext in the same scope. Both overlapping in variables names context.

What changes are included in this PR?

  • rename RestContext to RestClient
  • rename all variables from context to client
  • rename the retrieving function RestCatalog::context to RestCatalog::client
  • rename variables holding the lower-level HttpClient from client to http_client

Are these changes tested?

Via the compiler and the same test suite. No functional changes.

AI Disclosure

None 😱

@DerGut
DerGut marked this pull request as ready for review August 13, 2026 18:31

@CTTY CTTY left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR and it LGTM!

Do you mind addressing the recently merged auth_session naming in client.rs and catalog.rs here as well?

example:

session: Arc<dyn AuthSession>,

We should also to use with_auth_session here:

pub fn with_session(&self, session: Arc<dyn AuthSession>) -> Self {

I think renaming these can help us avoid confusion in the following development

@DerGut

DerGut commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Do you mind addressing the recently merged auth_session naming in client.rs and catalog.rs here as well?

Good point! I've pushed another commit.

@CTTY CTTY left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR!

@CTTY
CTTY merged commit 04b07e8 into apache:main Aug 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants