-
Notifications
You must be signed in to change notification settings - Fork 541
Add an internal Properties derive macro #2970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
894637b
Add derive properties macro
blackmwk a1fd056
Ready
blackmwk 0068cce
Fix property macro CI checks
blackmwk 4e35b2c
Remove write support
blackmwk 5896eea
Force attributes
blackmwk e9b6b6f
Merge remote-tracking branch 'upstream/main' into ir-2967
blackmwk 4f9f7da
Address property macro review feedback
blackmwk 49af143
Merge remote-tracking branch 'upstream/main' into ir-2967
blackmwk ccee9f8
Use Iceberg errors in generated property API
blackmwk 6ea3bb5
Require Iceberg results from property parsers
blackmwk 993188f
Manage property macro dependencies in workspace
blackmwk 1faa7fc
Sort workspace members alphabetically
blackmwk 7435f86
Exclude trybuild snapshots from license checks
blackmwk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| [package] | ||
| edition = { workspace = true } | ||
| homepage = { workspace = true } | ||
| name = "iceberg-property-macro" | ||
| publish = false | ||
| readme = "README.md" | ||
| rust-version = { workspace = true } | ||
| version = { workspace = true } | ||
|
|
||
| license = { workspace = true } | ||
| repository = { workspace = true } | ||
|
|
||
| categories = ["database"] | ||
| description = "Property derive macro for Apache Iceberg Rust" | ||
| keywords = ["iceberg"] | ||
|
|
||
| [lib] | ||
| proc-macro = true | ||
|
|
||
| [dependencies] | ||
| proc-macro2 = { workspace = true } | ||
| quote = { workspace = true } | ||
| syn = { workspace = true, features = ["full"] } | ||
|
|
||
| [dev-dependencies] | ||
| iceberg = { workspace = true } | ||
| serde = { workspace = true, features = ["derive"] } | ||
| serde_json = { workspace = true } | ||
| trybuild = { workspace = true } | ||
|
|
||
| [lints] | ||
| workspace = true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we drop a one-line comment on this? Nothing inside the
icebergcrate uses the alias — it's here purely so the#[derive(Properties)]output in other crates can resolve::iceberg::Error.Without a note, the next person doing dependency cleanup sees an unused self-alias, finds zero internal references, and deletes it, silently breaking the macro. Something like
// required so #[derive(Properties)] output can name ::iceberg::...; see crates/property-macrowould save that.