HIVE-29783: Iceberg CoW MERGE INTO missing column ambiguity check in the ON clause - #6685
Open
ludlows wants to merge 2 commits into
Open
HIVE-29783: Iceberg CoW MERGE INTO missing column ambiguity check in the ON clause#6685ludlows wants to merge 2 commits into
ON clause#6685ludlows wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
here we want to check the columns in the
ONclause ofMERGE INTOsyntax without being assigned table namesin case of copy on write table giving wrong results.
so, here we directly do not allow the unresolved columns in the
ONclause to pass the check point.the related issus is https://issues.apache.org/jira/si/jira.issueviews:issue-html/HIVE-29783/HIVE-29783.html .
The SQL used to reproduce the issue is like
Why are the changes needed?
copy-on-write has a different write behavior with that of merge-on-read.
if we do not check the unresolved columns in the
ONclause (make it a little more strict), the wrong logical plan is executed and produces wrong results.Does this PR introduce any user-facing change?
No
How was this patch tested?
both negative and positive test cases are added.