HIVE-29644: HMS hang/deadlock during ACID replication: compaction enqueue incorrectly runs inside replTableWriteIdState transaction#6522
Open
shreenidhiSaigaonkar wants to merge 1 commit into
Conversation
…ueue incorrectly runs inside replTableWriteIdState transaction - ReplTableWriteIdStateFunction enqueued major compactions inline (via CompactFunction) inside the long @transactional(POOL_TX) replTableWriteIdState call, holding the NEXT_COMPACTION_QUEUE_ID row lock across all partitions while re-acquiring the CompactionScheduler mutex; this could AB-BA deadlock with a concurrent compact() caller (initiator or another replication job) across the POOL_TX/POOL_MUTEX connection pools. - replTableWriteIdState now only applies the write-id state and returns whether compaction is needed; TransactionHandler.repl_tbl_writeid_state schedules the per-partition major compactions afterwards via ReplAbortedWriteCompactionScheduler, each in its own compact() transaction (restoring the pre-HIVE-27481 behaviour, same as manual ALTER TABLE COMPACT).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
replTableWriteIdState now only applies the write-id state and returns whether compaction is needed; TransactionHandler.repl_tbl_writeid_state schedules the per-partition major compactions afterwards via ReplAbortedWriteCompactionScheduler, each in its own compact() transaction (restoring the pre-HIVE-27481 behaviour, same as manual ALTER TABLE COMPACT).
Why are the changes needed?
ReplTableWriteIdStateFunction enqueued major compactions inline (via CompactFunction) inside the long @transactional(POOL_TX) replTableWriteIdState call, holding the NEXT_COMPACTION_QUEUE_ID row lock across all partitions while re-acquiring the CompactionScheduler mutex; this could AB-BA deadlock with a concurrent compact() caller (initiator or another replication job) across the POOL_TX/POOL_MUTEX connection pools.
Does this PR introduce any user-facing change?
No
How was this patch tested?