HIVE-14609: HS2 cannot drop a function whose associated jar file has been removed#6447
Merged
Conversation
|
deniskuzZ
reviewed
Apr 24, 2026
deniskuzZ
reviewed
Apr 24, 2026
Contributor
Author
|
single unrelated test failure, I'll restart once review is ready here |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
Add an extra metastore call in
DropFunctionAnalyzerif the function info retrieval wasn't successful.Why are the changes needed?
Because with the patch it's impossible to DROP a function whose associated jar is deleted, which is extremely inconvenient.
Does this PR introduce any user-facing change?
Under normal circumstances, no.
How was this patch tested?
Unit test added (
testDropSucceedsWhenJarUnavailableButFunctionInMetastore), also, more importantly, local HS2 testing is done, confirmed the behavior pre/post patch:important to note that DROP FUNCTION is apparently successful w/wo the patch, and and exception appears in HS2 logs (which is good), but the function is only dropped successfully with the patch
pre-patch:
post-patch:
in the log:
the exception appears in the log in both cases: