FINERACT-2657: Fix NPE updating a provisioning criteria by matching definitions on categoryId#6027
Open
oluexpert99 wants to merge 1 commit into
Open
Conversation
…efinitions on categoryId - ProvisioningCriteria.update matched incoming definitions by the surrogate id, but the public UPDATE payload keys each definition only by categoryId, so data.getId() was null and update() threw a NullPointerException (HTTP 500) on every provisioning-criteria update. - Match the existing definition by categoryId (its natural key, unique per criteria) and reject an unknown categoryId with a clean validation error instead of the NPE; add a getCategoryId() accessor on ProvisioningCriteriaDefinition. - Add ProvisioningCriteriaTest covering the match-by-categoryId update path and the unknown-category validation path. Signed-off-by: oluexpert99 <farooq@techservicehub.io>
d9295bf to
9406803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
payload keys each definition only by categoryId, so data.getId() was null and update() threw a
NullPointerException (HTTP 500) on every provisioning-criteria update.
unknown categoryId with a clean validation error instead of the NPE; add a getCategoryId() accessor
on ProvisioningCriteriaDefinition.
validation path.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.