Skip to content

FINERACT-2656: Fix NPE disbursing a loan with an account-transfer charge and no linked savings account#6026

Open
oluexpert99 wants to merge 1 commit into
apache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2656
Open

FINERACT-2656: Fix NPE disbursing a loan with an account-transfer charge and no linked savings account#6026
oluexpert99 wants to merge 1 commit into
apache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2656

Conversation

@oluexpert99

Copy link
Copy Markdown
Contributor

Description

  • Guard retriveLoanLinkedAssociation(...) for null in disburseLoan's account-transfer
    disbursement-charge loop, the down-payment auto-transfer block, and bulkLoanDisbursal's
    charge loop, throwing LinkedAccountRequiredException (as the disburse-to-savings path
    already does) instead of NullPointerException / HTTP 500.
  • Guard both TransferFeeChargeForLoansTasklet call sites so the scheduled job records the
    error and skips the misconfigured loan instead of aborting the batch.
  • Add LoanWritePlatformServiceJpaRepositoryImplTest coverage asserting the exception is
    raised and no account transfer is attempted when the loan has no linked savings account.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…rge and no linked savings account

- Guard retriveLoanLinkedAssociation(...) for null in disburseLoan's account-transfer
  disbursement-charge loop, the down-payment auto-transfer block, and bulkLoanDisbursal's
  charge loop, throwing LinkedAccountRequiredException (as the disburse-to-savings path
  already does) instead of NullPointerException / HTTP 500.
- Guard both TransferFeeChargeForLoansTasklet call sites so the scheduled job records the
  error and skips the misconfigured loan instead of aborting the batch.
- Add LoanWritePlatformServiceJpaRepositoryImplTest coverage asserting the exception is
  raised and no account transfer is attempted when the loan has no linked savings account.

Signed-off-by: oluexpert99 <farooq@techservicehub.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant