FINERACT-2656: Fix NPE disbursing a loan with an account-transfer charge and no linked savings account#6026
Open
oluexpert99 wants to merge 1 commit into
Open
Conversation
…rge and no linked savings account - Guard retriveLoanLinkedAssociation(...) for null in disburseLoan's account-transfer disbursement-charge loop, the down-payment auto-transfer block, and bulkLoanDisbursal's charge loop, throwing LinkedAccountRequiredException (as the disburse-to-savings path already does) instead of NullPointerException / HTTP 500. - Guard both TransferFeeChargeForLoansTasklet call sites so the scheduled job records the error and skips the misconfigured loan instead of aborting the batch. - Add LoanWritePlatformServiceJpaRepositoryImplTest coverage asserting the exception is raised and no account transfer is attempted when the loan has no linked savings account. Signed-off-by: oluexpert99 <farooq@techservicehub.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
disbursement-charge loop, the down-payment auto-transfer block, and bulkLoanDisbursal's
charge loop, throwing LinkedAccountRequiredException (as the disburse-to-savings path
already does) instead of NullPointerException / HTTP 500.
error and skips the misconfigured loan instead of aborting the batch.
raised and no account transfer is attempted when the loan has no linked savings account.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.