Skip to content

FINERACT-2291: Migrate Group activate, close, assignStaff, unassignStaff endpoints to typed command framework#6021

Open
nidhiii128 wants to merge 1 commit into
apache:developfrom
nidhiii128:FINERACT-2291-group-state-commands
Open

FINERACT-2291: Migrate Group activate, close, assignStaff, unassignStaff endpoints to typed command framework#6021
nidhiii128 wants to merge 1 commit into
apache:developfrom
nidhiii128:FINERACT-2291-group-state-commands

Conversation

@nidhiii128

Copy link
Copy Markdown
Contributor

Description

JIRA: https://issues.apache.org/jira/browse/FINERACT-2291

Migrates four Group state-change endpoints to the typed command framework:

  • POST /groups/{id}?command=activate
  • POST /groups/{id}?command=close
  • POST /groups/{id}?command=assignStaff
  • POST /groups/{id}?command=unassignStaff
  • POST /groups/{id}/command/unassign_staff (legacy dedicated path)

These endpoints now flow through Command/CommandHandler/CommandDispatcher
with typed request/response POJOs instead of JsonCommand. Legacy methods
retained on the service interface for backward compatibility with other
internal callers.

Pattern follows the merged StaffCreateCommand reference implementation:

  • Empty-body Command with @DaTa + @EqualsAndHashCode(callSuper = true)
  • CommandHandler<REQ, RES> with @Retry + fallback method
  • Lombok throughout, Jakarta Validation on requests
  • Permission checks in service impl (validateHasPermissionTo)

Note: run-api-backward-compatibility CI check may flag the response
shape change from CommandProcessingResult to typed responses
(intentional, part of FINERACT-2169 migration scope).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@nidhiii128 nidhiii128 force-pushed the FINERACT-2291-group-state-commands branch from e4f92c0 to 6a13753 Compare June 23, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant