FINERACT-2653: Fix provisioning category delete failing with mandatory categoryname error

[oluexpert99]

Fix provisioning category delete failing with mandatory category name error

• Load the category by command.entityId() instead of running create-validation on the body-less DELETE.
• Drop ProvisioningCategory.fromJson(command), which left the @id null so the in-use check and repository.delete() targeted a transient entity and never removed the row.
• Throw ProvisioningCategoryNotFoundException for an unknown id.
• Add ProvisioningCategoryWritePlatformServiceJpaRepositoryImplTest covering delete-success, not-found, and in-use-cannot-delete, asserting create-validation is never invoked on delete.

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[adamsaghy]

private boolean isAnyLoanProductsAssociateWithThisProvisioningCategory(final Long categoryId) {
    // The category is in use when a provisioning criteria definition references it. Querying the
    // m_loanproduct_provisioning_details table was incorrect because category_id belongs to
    // m_provisioning_criteria_definition. EXISTS is portable across PostgreSQL, MySQL and MariaDB,
    // and avoids counting all matching rows.
    final String sql = """
            select exists (
                select 1
                from m_provisioning_criteria_definition
                where category_id = ?
            )
            """;

    final Boolean exists = this.jdbcTemplate.queryForObject(sql, Boolean.class, categoryId);
    return Boolean.TRUE.equals(exists);
}

Might be even better, no? Can you please look into it?

[oluexpert99]

Thanks @adamsaghy . This has been updated

[adamsaghy]

@oluexpert99 Please review the failing checks.

[oluexpert99]

Hi @adamsaghy . does not look like a check failure

[oluexpert99]

@adamsaghy . checks passed