FINERACT-2291: New command processing - create group#6007
Open
nidhiii128 wants to merge 1 commit into
Open
Conversation
ccfc544 to
9740ae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the "create group" REST endpoint (POST
/v1/groups) from the legacy JSON-blob command-processing path to the new typed fineract-command framework.Scope (PR 1 of 3 for FINERACT-2291)
GroupCreateRequest/GroupCreateResponsePOJOs with Jakarta Validation (@NotBlank,@NotNull,@Size,@Positive,@AssertTruefor conditional activation date)DatatableEntryPOJO for thedatatablesfield (with@Validcascade and@NotBlankonregisteredTableName)String+ manual parsing inside the impl (honoring requestdateFormatandlocale) to match Fineract's existing date-handling conventionGroupCreateCommandandGroupCreateCommandHandlerusingCommandHandler<REQ, RES>GroupingTypesWritePlatformServicegets a new typedcreateGroup(GroupCreateRequest)overload (legacycreateGroup(Long, JsonCommand)kept since other endpoints still use it)POST /v1/groupsnow routes throughCommandDispatcherSecurityConfigforPOST /api/*/groupswithCREATE_GROUPpermissioncommandGroupCreateinapplication.propertiesValidationMessages.propertiesCreateGroupCommandHandlerdeletedNot in this PR (follow-up)
accountNouser-supplied override field -> currently auto-generated onlycollectionMeetingCalendarfield -> needs typed structureChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.