feat: add support for column-based reading of CSV files - #982
Conversation
bca58fe to
ab2343a
Compare
|
@delei @bengbengbalabalabeng pls run CI on this |
|
Please resolve the code conflict issue first. |
315c615 to
069413c
Compare
38a41b4 to
9861270
Compare
| List<Map<Integer, String>> readResults = FesodSheet.read(csvFile) | ||
| .csv() | ||
| .includeColumnIndexes(targetColumns) | ||
| .sheet(0) | ||
| .doReadSync(); |
There was a problem hiding this comment.
Method call chain error.
There was a problem hiding this comment.
Can you point out the test example?
There was a problem hiding this comment.
The includeColumnIndexes() method is not defined in .csv() (CsvReaderBuilder).
There was a problem hiding this comment.
The includeColumnIndexes() method is not defined in .read(...) (ExcelReaderBuilder).
Please confirm that the unit tests pass locally before submitting.
There was a problem hiding this comment.
@bengbengbalabalabeng the test now passes locally, pls check again and merge this if all is ok.
f99a1a4 to
d71205b
Compare
|
@bengbengbalabalabeng @delei is csv supporting non header data? as of now the default is 1 so the first row will always be skipped (because it is considered header) when reading data |
|
|
Hi @sapienza88, Please help confirm whether the updated PR description accurately reflects the changes. |
Yes it does. Thanks |
bengbengbalabalabeng
left a comment
There was a problem hiding this comment.
LGTM.
merge in 24h.
Purpose of the pull request
Related: #950
Related: #942 (XLSX Format Implementation)
What's changed?
Column filtering behavior:
CsvExcelReadExecutor#dealRecordWhen
includeColumnIndexes != null:When
includeColumnIndexes == null:API Usage Example
Checklist