Skip to content

feat: add support for column-based reading of XLS files - #981

Open
sapienza88 wants to merge 6 commits into
apache:mainfrom
sapienza88:column_support_xls
Open

feat: add support for column-based reading of XLS files#981
sapienza88 wants to merge 6 commits into
apache:mainfrom
sapienza88:column_support_xls

Conversation

@sapienza88

@sapienza88 sapienza88 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Related #942

Summary: Column-based filtering support for XLS.

What's changed?
Added support for column-based reading for XLS

@nkuprins

Copy link
Copy Markdown
Contributor

I am not a maintainer, but it might be worth checking contribution guide, as the commit messages and PR don't seem to follow the format :)

@sapienza88

Copy link
Copy Markdown
Contributor Author

I am not a maintainer, but it might be worth checking contribution guide, as the commit messages and PR don't seem to follow the format :)

Unless you have a genuine reason related to the review of this PR, I don't feel obliged to respond to your inquiry. It is indeed up to the maintainers of this project to ask me this and only then I can proceed to the modifications.

@delei

delei commented Jul 30, 2026

Copy link
Copy Markdown
Member

We are grateful to all the volunteers.

All contributors and committers can voluntarily participate in the code review process, have friendly exchanges, and offer their own suggestions.

Although the contribution guidelines are not binding or mandatory, following them can help community members understand the content of PR, which can effectively save time.

@sapienza88

sapienza88 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

We are grateful to all the volunteers.

All contributors and comitters can voluntarily participate in the code review process, have friendly exchanges, and offer their own suggestions.

Although the contribution guidelines are not binding or mandatory, following them can help community members understand the content of PR, which can effectively save time.

@delei if anyone has an inquiry about this PR to "understand the content of PR", they can ask directly, but to ask to follow any guideline it is not their responsability as far as I know (+ this PR is a follow-up one to a previous related well-documented merged PR: which makes this PR relatively easier to understand).

@nkuprins

nkuprins commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

We are grateful to all the volunteers.
All contributors and comitters can voluntarily participate in the code review process, have friendly exchanges, and offer their own suggestions.
Although the contribution guidelines are not binding or mandatory, following them can help community members understand the content of PR, which can effectively save time.

@delei if anyone has an inquiry about this PR to "understand the content of PR", they can ask directly, but to ask to follow any guideline it is not their responsability as far as I know.

I don't want to spam the thread, but FYI, I was looking at the PR content (not just commit messages). I do this because I have a genuine interest in the project. Besides, Apache is about community, so I obviously have a genuine interest in the code of other people and not just my own.

Regarding formatting guidelines. It was meant to be a kind remark that I noticed and verified. Commit messages and PR template are important to help to understand the code for other people. I did not require you to do anything, as I said "might be worth checking". After that, I wanted to ask the question about the content, but that takes time to verify to be 100% sure.

For your convenience, I will refrain from any remarks specifically about your code or formatting in the future.

Let's end on this and not spam the thread, please :)

@sapienza88
sapienza88 force-pushed the column_support_xls branch from 70d51d8 to b394c30 Compare July 30, 2026 22:22
@sapienza88 sapienza88 changed the title Column-Based Filtering Support for XLS Feat: Column-Based Filtering Support for XLS Aug 2, 2026
@sapienza88

Copy link
Copy Markdown
Contributor Author

@bengbengbalabalabeng can you merge this if all is ok?

@bengbengbalabalabeng bengbengbalabalabeng added the PR: reviewing Currently under active review. label Aug 4, 2026
@delei delei changed the title Feat: Column-Based Filtering Support for XLS feat: add support for column-based reading of XLS files Aug 5, 2026
@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

Please also add the following cell record types in sync: LabelRecordHandler, FormulaRecordHandler, RKRecordHandler, BoolErrRecordHandler, BlankRecordHandler, DummyRecordHandler -> MissingCellDummyRecord, to ensure read consistency of XLS under column-based filtering.

@sapienza88

Copy link
Copy Markdown
Contributor Author

Please also add the following cell record types in sync: LabelRecordHandler, FormulaRecordHandler, RKRecordHandler, BoolErrRecordHandler, BlankRecordHandler, DummyRecordHandler -> MissingCellDummyRecord, to ensure read consistency of XLS under column-based filtering.

Yes I was planning that in a seperate PR

@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

Yes I was planning that in a seperate PR

No need to split off a new PR, just keep refining it in the current one, which also makes the overall review easier.

@sapienza88

Copy link
Copy Markdown
Contributor Author

Yes I was planning that in a seperate PR

No need to split off a new PR, just keep refining it in the current one, which also makes the overall review easier.

@bengbengbalabalabeng OK

@delei

delei commented Aug 5, 2026

Copy link
Copy Markdown
Member

If the timeline is uncertain, you can leave a comment in the existing issue #950 outlining your plans or the remaining tasks, and we can assign the task to you.

If it is not completed by the release milestone, we will allow other volunteers to continue contributing and refining it.

@sapienza88

Copy link
Copy Markdown
Contributor Author

@bengbengbalabalabeng pls check the progress through the latest commit. @delei

@bengbengbalabalabeng

Copy link
Copy Markdown
Contributor

In the previous XLSX format implementation, extended record types such as Note were not included in the column filtering logic.

The current PR mainly focuses on column index mapping for regular cell records to ensure consistency in the core reading flow.

NOTE (NoteRecordHandler) is an extended optional record type that typically does not participate in the main dataset processing flow. Therefore, whether additional handling of the NOTE (NoteRecordHandler) type is needed this time, you may want to confirm the requirement scope.

@sapienza88

sapienza88 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

The current PR mainly focuses on column index mapping for regular cell records to ensure consistency in the core reading flow.

NOTE (NoteRecordHandler) is an extended optional record type that typically does not participate in the main dataset processing flow. Therefore, whether additional handling of the NOTE (NoteRecordHandler) type is needed this time, you may want to confirm the requirement scope.

that's correct, NOTE metadata is not needed in the context of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: reviewing Currently under active review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants