FELIX-6849 : Apply org.eclipse.jetty.UriComplianceMode to redirect URIs#534
Merged
Conversation
Felix jetty12 mapped the org.eclipse.jetty.UriComplianceMode property to HttpConfiguration.setUriCompliance() only, leaving redirect URI compliance at Jetty's default. Since Jetty 12.1 that default rejects ambiguous encodings (e.g. %2F) in the Location header, so a deployment relaxing request URI compliance (e.g. LEGACY) still had its redirects rejected. Apply the configured compliance to setRedirectUriCompliance() as well, so the mode takes effect end-to-end. Behavior is unchanged when the property is unset (Jetty defaults still apply). Added redirect URI compliance coverage to the default and LEGACY integration tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…dule The itest default http.jetty.version was still 2.0.1-SNAPSHOT, while the jetty12 module is now 2.0.3-SNAPSHOT. The stale reference transitively pulled in org.apache.felix.http.base:6.0.0-SNAPSHOT, which no longer exists (base is now 6.0.1-SNAPSHOT), breaking dependency resolution in CI. Bump the property to 2.0.3-SNAPSHOT so the current in-reactor jetty12 (and http.base 6.0.1-SNAPSHOT) is used. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The jetty11 profile still pinned http.jetty.version=5.2.3-SNAPSHOT, while the jetty (jetty9) module is now 5.2.5-SNAPSHOT. Align it so that profile resolves the current in-reactor module (and http.base 6.0.1-SNAPSHOT) instead of a stale, non-existent snapshot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FELIX-6849
Felix jetty12 mapped the org.eclipse.jetty.UriComplianceMode property to HttpConfiguration.setUriCompliance() only, leaving redirect URI compliance at Jetty's default. Since Jetty 12.1 that default rejects ambiguous encodings (e.g. %2F) in the Location header, so a deployment relaxing request URI compliance (e.g. LEGACY) still had its redirects rejected.
Apply the configured compliance to setRedirectUriCompliance() as well, so the mode takes effect end-to-end. Behavior is unchanged when the property is unset (Jetty defaults still apply).
Added redirect URI compliance coverage to the default and LEGACY integration tests.