fix: JavaBeanSerializeUtil handles null key in Map serialization - #16435
Open
waterWang wants to merge 2 commits into
Open
fix: JavaBeanSerializeUtil handles null key in Map serialization#16435waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16435 +/- ##
============================================
- Coverage 36.93% 36.90% -0.03%
+ Complexity 11752 11744 -8
============================================
Files 1952 1952
Lines 89249 89250 +1
Branches 13389 13389
============================================
- Hits 32961 32940 -21
- Misses 51710 51724 +14
- Partials 4578 4586 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes #16432:
JavaBeanSerializeUtil.serialize()throwsIllegalArgumentException("Property name is null")when serializing aMapthat contains anullkey.HashMappermits exactly onenullkey, so this is a legal input. The Map branch inserializeInternalexplicitly handles null keys (key == null ? null : createDescriptorIfAbsent(...)), but the descriptor produced is then rejected by thenotNullcheck inJavaBeanDescriptor.setProperty().Root cause
In
JavaBeanSerializeUtil.serializeInternal()Map branch:When the map has a null key,
keyDescriptorisnull, andJavaBeanDescriptor.setProperty(null, value)throws because of thenotNull(propertyName, "Property name is null")guard.Fix
Relax the
notNullguard inJavaBeanDescriptor.setProperty()for map-type descriptors only — anullkey is a legal Map key andLinkedHashMap(the backing storage) supports it. Bean/array/collection/class/enum descriptors keep the original null check.Verification
testSerialize_MapWithNullKey(round-trip test: map with a null key serializes, deserializes, and preserves both key-value pairs)JavaBeanSerializeUtilTestsuite unaffectedChecklist
3.3branch