Skip to content

[fix](bdbje) Reuse TLS config for group administration - #67224

Open
Yukang-Lian wants to merge 2 commits into
apache:masterfrom
Yukang-Lian:codex/tls9-bdbje-admin-tls
Open

[fix](bdbje) Reuse TLS config for group administration#67224
Yukang-Lian wants to merge 2 commits into
apache:masterfrom
Yukang-Lian:codex/tls9-bdbje-admin-tls

Conversation

@Yukang-Lian

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: N/A

Related PR: selectdb/selectdb-core#10972

Problem Summary: ReplicationGroupAdmin was created with the two-argument constructor, which builds its own default network channel factory instead of using the ReplicationConfig that initialized BDBJE. In a TLS-enabled replication group, administrative operations therefore attempt a plaintext connection. Pass the active RepNetConfig so group administration reuses the configured TLS channel factory.

Release note

BDBJE replication-group administration now uses the configured replication TLS transport.

Check List (For Author)

  • Test: Unit Test: ./run-fe-ut.sh --run org.apache.doris.journal.bdbje.BDBEnvironmentTest#testReplicationGroupAdminReusesConfiguredNetworkFactory (1 passed)
  • Behavior changed: Yes. ReplicationGroupAdmin reuses the active BDBJE network configuration.
  • Does this need documentation: No

### What problem does this PR solve?

Issue Number: N/A

Related PR: selectdb/selectdb-core#10972

Problem Summary: ReplicationGroupAdmin was created with the two-argument constructor, which builds its own default network channel factory instead of using the ReplicationConfig that initialized BDBJE. In a TLS-enabled replication group, administrative operations therefore attempt a plaintext connection. Pass the active RepNetConfig so group administration reuses the configured TLS channel factory.

### Release note

BDBJE replication-group administration now uses the configured replication TLS transport.

### Check List (For Author)

- Test: Unit Test: ./run-fe-ut.sh --run org.apache.doris.journal.bdbje.BDBEnvironmentTest#testReplicationGroupAdminReusesConfiguredNetworkFactory (1 passed)
- Behavior changed: Yes. ReplicationGroupAdmin reuses the active BDBJE network configuration.
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants