[fix](regression) Preserve external JDBC URLs in TLS mode - #67222
Open
Yukang-Lian wants to merge 1 commit into
Open
[fix](regression) Preserve external JDBC URLs in TLS mode#67222Yukang-Lian wants to merge 1 commit into
Yukang-Lian wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: apache#66289 Problem Summary: SuiteContext.connect() appended Doris mTLS parameters to every caller-provided JDBC URL and returned the rewritten string before opening a connection. External JDBC setup closures therefore did not run in TLS regression jobs. Keep connect() protocol-agnostic and open the exact URL supplied by the caller; the default Doris JDBC URL already receives its TLS options in Config.createDefaultDb(). ### Release note None ### Check List (For Author) - Test: Unit Test: mvn -Dtest=SuiteContextConnectTest test (1 passed) - Behavior changed: Yes. External JDBC connections now preserve their supplied URL and execute their setup closure when regression TLS mode is enabled. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #66289
Problem Summary: SuiteContext.connect() appended Doris mTLS parameters to every caller-provided JDBC URL and returned the rewritten string before opening a connection. External JDBC setup closures therefore did not run in TLS regression jobs. Keep connect() protocol-agnostic and open the exact URL supplied by the caller; the default Doris JDBC URL already receives its TLS options in Config.createDefaultDb().
Release note
None
Check List (For Author)