Skip to content

[fix](regression) Preserve external JDBC URLs in TLS mode - #67222

Open
Yukang-Lian wants to merge 1 commit into
apache:masterfrom
Yukang-Lian:codex/tls10-external-jdbc-tls
Open

[fix](regression) Preserve external JDBC URLs in TLS mode#67222
Yukang-Lian wants to merge 1 commit into
apache:masterfrom
Yukang-Lian:codex/tls10-external-jdbc-tls

Conversation

@Yukang-Lian

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: N/A

Related PR: #66289

Problem Summary: SuiteContext.connect() appended Doris mTLS parameters to every caller-provided JDBC URL and returned the rewritten string before opening a connection. External JDBC setup closures therefore did not run in TLS regression jobs. Keep connect() protocol-agnostic and open the exact URL supplied by the caller; the default Doris JDBC URL already receives its TLS options in Config.createDefaultDb().

Release note

None

Check List (For Author)

  • Test: Unit Test: mvn -Dtest=SuiteContextConnectTest test (1 passed)
  • Behavior changed: Yes. External JDBC connections now preserve their supplied URL and execute their setup closure when regression TLS mode is enabled.
  • Does this need documentation: No

### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#66289

Problem Summary: SuiteContext.connect() appended Doris mTLS parameters to every caller-provided JDBC URL and returned the rewritten string before opening a connection. External JDBC setup closures therefore did not run in TLS regression jobs. Keep connect() protocol-agnostic and open the exact URL supplied by the caller; the default Doris JDBC URL already receives its TLS options in Config.createDefaultDb().

### Release note

None

### Check List (For Author)

- Test: Unit Test: mvn -Dtest=SuiteContextConnectTest test (1 passed)
- Behavior changed: Yes. External JDBC connections now preserve their supplied URL and execute their setup closure when regression TLS mode is enabled.
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants