Skip to content

[fix](storage) Reject prepare txn on shutdown tablet (#66448) - #67217

Open
deardeng wants to merge 1 commit into
apache:branch-4.0from
deardeng:codex/pick-66448-to-branch-4.0
Open

[fix](storage) Reject prepare txn on shutdown tablet (#66448)#67217
deardeng wants to merge 1 commit into
apache:branch-4.0from
deardeng:codex/pick-66448-to-branch-4.0

Conversation

@deardeng

Copy link
Copy Markdown
Contributor

pick from #66448

Call the Tablet-aware transaction preparation overload while migration and push locks are held, restoring the shutdown-tablet guard and preventing stale tablet transaction entries.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

pick from apache#66448

Call the Tablet-aware transaction preparation overload while migration and push locks are held, restoring the shutdown-tablet guard and preventing stale tablet transaction entries.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.63% (19648/36633)
Line Coverage 36.70% (184118/501672)
Region Coverage 33.22% (142971/430432)
Branch Coverage 34.09% (61827/181367)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.53% (25633/35836)
Line Coverage 54.49% (272458/499997)
Region Coverage 52.01% (225650/433827)
Branch Coverage 53.41% (97085/181779)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants