Aggregate byte types internally with i64 offsets#23695
Open
maxburke wants to merge 1 commit into
Open
Conversation
…ces back to i32-offset-types as necessary.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23695 +/- ##
=======================================
Coverage 80.67% 80.67%
=======================================
Files 1088 1088
Lines 367591 367673 +82
Branches 367591 367673 +82
=======================================
+ Hits 296563 296636 +73
- Misses 53374 53375 +1
- Partials 17654 17662 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and downcast back to i32-offset-types as necessary.
Which issue does this PR close?
Closes #23694 (and possibly apache/datafusion-comet#4718)
Rationale for this change
Fixes an error when grouping on large string/binary data
What changes are included in this PR?
Inner core groups using i64 offsets and then downcasts to correct type when emitting batch slices
Are these changes tested?
Yes
Are there any user-facing changes?
No