feat: improve pythonic interface on date/time functions#1563
Draft
timsaucer wants to merge 1 commit into
Draft
Conversation
Widen date/time scalar function signatures to accept native Python
``str``/``int`` literals alongside ``Expr``:
- ``date_bin``: ``stride``, ``source``, ``origin`` accept ``Expr | str``.
- ``make_date``, ``make_time``: components accept ``Expr | int``.
- ``to_date``, ``to_time``, ``to_timestamp``, ``to_timestamp_{millis,
micros,nanos,seconds}``, ``to_unixtime``: ``*formatters`` accept
``Expr | str``.
Add ``coerce_to_expr_list`` public helper in ``datafusion.expr`` mirroring
``coerce_to_expr`` / ``ensure_expr_list`` for variadic call sites.
``date_bin`` uses ``Expr.string_literal`` directly because its planner
coerces ``Utf8`` (not ``Utf8View``) literals to ``Interval``/``Timestamp``.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ongoing ergonomic improvements, but no specific issue.
Rationale for this change
This PR makes a lot of the date/time functions take strings or integer when appropriate. This makes the code cleaner so that users don't always have to wrap these in a
lit()call.What changes are included in this PR?
Python changes only. When a
strorint(as appropriate) is found, coerce it to a literal.Are there any user-facing changes?
Prior code works as is. This simply makes newer code easier to write.