chore: add math benches - #5479
Open
coderfender wants to merge 2 commits into
Open
Conversation
coderfender
marked this pull request as draft
August 26, 2026 18:50
coderfender
marked this pull request as ready for review
August 27, 2026 02:41
coderfender
force-pushed
the
bench_math_scalar_expr
branch
2 times, most recently
from
August 27, 2026 03:05
0433277 to
fe986a0
Compare
coderfender
force-pushed
the
bench_math_scalar_expr
branch
from
August 27, 2026 04:00
fe986a0 to
7c01c37
Compare
sunchao
approved these changes
Aug 27, 2026
sunchao
left a comment
sunchao
left a comment
Member
There was a problem hiding this comment.
Rechecked 7c01c37291abe677477cc35fc5d68534865fe836: the shared-helper lint issue is fixed. Fresh focused lint checks, benchmark smoke runs, and native output assertions pass; no outstanding P1/P2 findings.
Contributor
Author
|
Thank you for the approval @sunchao , I will merge it once CI passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5396.
Rationale for this change
The native scalar math kernels spark_log, spark_pow, and abs have no criterion coverage, so there's no baseline to guard against regressions when tuning them
What changes are included in this PR?
Benchmark-only, no behavior change
How are these changes tested?
Run locally