chore: Use native impl of soundex function#4824
Open
kazantsev-maksim wants to merge 60 commits into
Open
Conversation
This reverts commit 768b3e9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR migrates the
soundexstring function from Comet's codegen-based dispatch path to the shareddatafusion-sparkimplementation, registering it as a native scalar UDF.What changes are included in this PR?
SparkSoundexscalar UDF in register_datafusion_spark_function so it is available to the DataFusion session context alongside the other Spark-compatible UDFs.CometCodegenDispatch[SoundEx]toCometScalarFunction[SoundEx]("soundex")How are these changes tested?
Significantly expand the test coverage with many additional inputs to exercise edge cases