feat: use macro to expose ballista config options - #2387
Open
milenkovicm wants to merge 7 commits into
Open
Conversation
milenkovicm
marked this pull request as ready for review
August 27, 2026 09:29
milenkovicm
requested review from
Dandandan,
andygrove,
avantgardnerio and
martin-g
August 27, 2026 09:29
milenkovicm
changed the title
milenkovicm
marked this pull request as draft
August 27, 2026 09:32
milenkovicm
marked this pull request as ready for review
August 27, 2026 10:09
martin-g
reviewed
Aug 27, 2026
| } | ||
|
|
||
| /// Deprecated alias for [`Self::standalone_parallelism`]. | ||
| #[deprecated(note = "renamed to `standalone_parallelism`")] |
Member
There was a problem hiding this comment.
Suggested change
| #[deprecated(note = "renamed to `standalone_parallelism`")] | |
| #[deprecated(since = "55.0.0", note = "renamed to `standalone_parallelism`")] |
this makes it easier to decide when it is time to remove the deprecated method.
| } | ||
|
|
||
| /// Deprecated alias for [`Self::use_tls`]. | ||
| #[deprecated(note = "renamed to `use_tls`")] |
Member
There was a problem hiding this comment.
Suggested change
| #[deprecated(note = "renamed to `use_tls`")] | |
| #[deprecated(since = "55.0.0", note = "renamed to `use_tls`")] |
Comment on lines
+1095
to
+1096
| let plain = SessionConfig::new_with_ballista() | ||
| .with_ballista_standalone_parallelism(123) |
Member
There was a problem hiding this comment.
Suggested change
| let plain = SessionConfig::new_with_ballista() | |
| .with_ballista_standalone_parallelism(123) | |
| let plain = SessionConfig::new_with_ballista() | |
| .with_ballista_adaptive_query_planner(true) | |
| .with_ballista_standalone_parallelism(123) |
| .with_ballista_coalesce_small_partition_factor(1.5) | ||
| .with_ballista_coalesce_merged_partition_factor(2.5); | ||
|
|
||
| assert!(plain.ballista_shuffle_reader_force_remote_read()); |
Member
There was a problem hiding this comment.
Suggested change
| assert!(plain.ballista_shuffle_reader_force_remote_read()); | |
| assert!(plain.ballista_adaptive_query_planner_enabled()); | |
| assert!(plain.ballista_shuffle_reader_force_remote_read()); |
| assert_eq!( | ||
| plain.ballista_shuffle_reader_maximum_concurrent_requests(), | ||
| 7 | ||
| ); |
Member
There was a problem hiding this comment.
Should the deprecated getters be tested too ?
Contributor
Author
There was a problem hiding this comment.
this one is not deprecated,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We had quite a lot of boiler plate code to expose ballista config option, also exposed names might differ.
Also we did not have uniform naming strategy for exposed configuration properties
What changes are included in this PR?
Are there any user-facing changes?
Yes, some config names have changed