feat: scheduler REST & GRPC return version headers - #2378
Open
milenkovicm wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
not sure if this could cover #2370 requirements. |
avantgardnerio
self-requested a review
August 25, 2026 20:57
avantgardnerio
left a comment
avantgardnerio
left a comment
Contributor
There was a problem hiding this comment.
I strongly support this, but the warn! could be an issue if we intend to keep the 54 -> 55 version compatibility @andygrove suggested. If it causes users to see a warning all the time, even in supported use-cases, they'll just ignore it. I'll wait for Andy to weigh in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2370.
Rationale for this change
scheduler returns version headers which client can compare with expected version.
schedule returns two additional header
client which check
server/VERSIONand logs warning in case of mismatchWhat changes are included in this PR?
Are there any user-facing changes?