fix(ios): Use CDVSettingsDictionary instead of NSMutableDictionary, small refactoring - #657
Open
GitToTheHub wants to merge 2 commits into
Open
fix(ios): Use CDVSettingsDictionary instead of NSMutableDictionary, small refactoring#657GitToTheHub wants to merge 2 commits into
CDVSettingsDictionary instead of NSMutableDictionary, small refactoring#657GitToTheHub wants to merge 2 commits into
Conversation
…y, small refactoring - self.viewController.settings was assigned to a local variable typed `NSMutableDictionary`. ` self.viewController.settings` is used directly. - Add type alias NSDictionary to CDVSettingsDictionary when using cordova-ios 7 and older - Don't check if self.viewController is kind of class CDVViewController. CDVViewController was introduced in Cordova 2.0.0. - Refactored method `getExtraFileSystemsPreference`
GitToTheHub
changed the title
CDVSettingsDictionary instead of NSMutableDictionary, small refactoringCDVSettingsDictionary instead of NSMutableDictionary, small refactoring
GitToTheHub
changed the title
CDVSettingsDictionary instead of NSMutableDictionary, small refactoringCDVSettingsDictionary instead of NSMutableDictionary, small refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
NSMutableDictionary.self.viewController.settingsis used directly.getExtraFileSystemsPreferenceDescription
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))