Skip to content

fix(statusbar): hide status bar correctly #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GitToTheHub wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

fix(statusbar): hide status bar correctly #2000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion framework/src/org/apache/cordova/CordovaActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ protected void createViews() {
WindowInsetsCompat.Type.systemBars() | WindowInsetsCompat.Type.displayCutout()
);

boolean isStatusBarVisible = statusBarView.getVisibility() != View.GONE;
boolean isStatusBarVisible = statusBarView.getVisibility() != View.GONE
&& insets.isVisible(WindowInsetsCompat.Type.statusBars());
int top = isStatusBarVisible && !canEdgeToEdge && !isFullScreen ? bars.top : 0;
int left = !canEdgeToEdge && !isFullScreen ? bars.left : 0;
int right = !canEdgeToEdge && !isFullScreen ? bars.right : 0;
Expand Down
11 changes: 11 additions & 0 deletions framework/src/org/apache/cordova/SystemBarPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Licensed to the Apache Software Foundation (ASF) under one
import androidx.core.content.ContextCompat;
import androidx.core.view.ViewCompat;
import androidx.core.view.WindowCompat;
import androidx.core.view.WindowInsetsCompat;
import androidx.core.view.WindowInsetsControllerCompat;

import org.json.JSONArray;
Expand Down Expand Up @@ -101,6 +102,16 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
* @param visible should the status bar be visible?
*/
private void setStatusBarVisible(final boolean visible) {
Window window = cordova.getActivity().getWindow();
WindowInsetsControllerCompat controller = WindowCompat.getInsetsController(window, window.getDecorView());
if (visible) {
controller.show(WindowInsetsCompat.Type.statusBars());
} else {
// Reveal the hidden bar temporarily as an overlay when swiped from the top.
controller.setSystemBarsBehavior(WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE);
controller.hide(WindowInsetsCompat.Type.statusBars());
}

View statusBar = getStatusBarView(webView);
if (statusBar != null) {
statusBar.setVisibility(visible ? View.VISIBLE : View.GONE);
Expand Down