-
Notifications
You must be signed in to change notification settings - Fork 301
Clear delimiter buffer before each peek in isDelimiter #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
garydgregory
merged 2 commits into
apache:master
from
rootvector2:delimiter-buffer-clear
Jun 17, 2026
+29
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -433,6 +433,19 @@ void testPartialMultiCharacterDelimiterAtEOF() throws IOException { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * A truncated multi-character delimiter at EOF must not be accepted by reusing the look-ahead buffer left dirty by an | ||
| * earlier non-matching peek in the same token (CSV-324 only cleared the buffer once per token). | ||
| */ | ||
| @Test | ||
| void testPartialMultiCharacterDelimiterAtEOFAfterMismatch() throws IOException { | ||
| final CSVFormat format = CSVFormat.DEFAULT.builder().setDelimiter("[|]").get(); | ||
| // The "[a]" peek leaves ']' in the look-ahead buffer; the trailing "[|" must not match "[|]". | ||
| try (Lexer lexer = createLexer("x[a][|", format)) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for your update. In the future, please make magic strings like |
||
| assertNextToken(EOF, "x[a][|", lexer); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| void testReadEscapeBackspace() throws IOException { | ||
| try (Lexer lexer = createLexer("b", CSVFormat.DEFAULT.withEscape('\b'))) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rootvector2
Thank you for your update.
In the future, please make magic strings like
"x[a][|"a local variable such that you never have to check that the assertion below is checking for a possibly different value.