Skip to content

tests: add unit tests for console proxy url - #2800

Merged
yadvr merged 1 commit into
apache:masterfrom
resmo:tests/consoleproxyiamgeurl
Aug 14, 2018
Merged

tests: add unit tests for console proxy url#2800
yadvr merged 1 commit into
apache:masterfrom
resmo:tests/consoleproxyiamgeurl

Conversation

@resmo

@resmo resmo commented Aug 13, 2018

Copy link
Copy Markdown
Member

Description

follow up of #2734

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

#2734

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@yadvr
yadvr merged commit 2930a60 into apache:master Aug 14, 2018
@yadvr

yadvr commented Aug 14, 2018

Copy link
Copy Markdown
Member

LGTM, unit test validated by travis.

@resmo
resmo deleted the tests/consoleproxyiamgeurl branch August 14, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants