Skip to content

maven: bump up vmware sdk jar to 6.7 - #2727

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:vmware67-sdk-upgrade
Jul 6, 2018
Merged

maven: bump up vmware sdk jar to 6.7#2727
yadvr merged 1 commit into
apache:4.11from
shapeblue:vmware67-sdk-upgrade

Conversation

@yadvr

@yadvr yadvr commented Jul 2, 2018

Copy link
Copy Markdown
Member

This bumps up the vmware jar dependency to 6.7.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.2.0 milestone Jul 2, 2018
@yadvr

yadvr commented Jul 2, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Jul 2, 2018
@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2158

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

@yadvr

yadvr commented Jul 5, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan package
@borisstoyanov when you've time this/next week, can you help investigate why packaging is failing?

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2162

@yadvr

yadvr commented Jul 5, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan test centos7 vmware-55u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2836)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38700 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2727-t2836-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_cancel_host_maintenace_with_migration_jobs Error 127.85 test_host_maintenance.py

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
yadvr merged commit c1ca45a into apache:4.11 Jul 6, 2018
@onitake

onitake commented May 29, 2019

Copy link
Copy Markdown
Contributor

@rhtyd @borisstoyanov Can you rerun the tests against ESXi 6.5 (and/or 6.0 and 6.7) to be sure it works in all supported and soon-to-be-supported (4.11.3) configurations?
Or am I missing something here?

@yadvr

yadvr commented May 30, 2019

Copy link
Copy Markdown
Member Author

I had recently ran tests against vmware 6.5u2, no regressions seen other than usual intermittent environment caused failures @onitake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants