Skip to content

capacity: remove unused threadpool - #2588

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:remove-unused-executor
Apr 19, 2018
Merged

capacity: remove unused threadpool#2588
yadvr merged 1 commit into
apache:4.11from
shapeblue:remove-unused-executor

Conversation

@yadvr

@yadvr yadvr commented Apr 19, 2018

Copy link
Copy Markdown
Member

This removes unused injectables and threadpool.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

This removes unused injectables and threadpool.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.1.0 milestone Apr 19, 2018
@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1956

@yadvr
yadvr requested a review from nvazquez April 19, 2018 19:06

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr

yadvr commented Apr 19, 2018

Copy link
Copy Markdown
Member Author

Thanks all, I'll merge this based on travis test results and code reviews. Since this is a cleanup in java, build and packaging jobs + travis smoke tests are good enough for evaluation.

@yadvr
yadvr merged commit f46518a into apache:4.11 Apr 19, 2018
@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants