Skip to content

Use double quotes with 'RROUTER' variable in "common.sh" script - #2586

Merged
yadvr merged 1 commit into
apache:4.11from
rafaelweingartner:commonScriptFix
Apr 19, 2018
Merged

Use double quotes with 'RROUTER' variable in "common.sh" script#2586
yadvr merged 1 commit into
apache:4.11from
rafaelweingartner:commonScriptFix

Conversation

@rafaelweingartner

Copy link
Copy Markdown
Member

Description

While debugging the VR for #2579, I noticed that one of the scripts were breaking. The variable RROUTER was not set and this broke a conditional.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Locally

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1954

@yadvr
yadvr requested review from DaanHoogland and nvazquez April 19, 2018 18:14

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr
yadvr changed the base branch from master to 4.11 April 19, 2018 18:53
@yadvr
yadvr changed the base branch from 4.11 to master April 19, 2018 18:53
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
yadvr force-pushed the commonScriptFix branch from b237c6b to eda9ee1 Compare April 19, 2018 18:56
@yadvr
yadvr changed the base branch from master to 4.11 April 19, 2018 18:56
@yadvr yadvr modified the milestones: 4.12.0.0, 4.11.1.0 Apr 19, 2018
@yadvr

yadvr commented Apr 19, 2018

Copy link
Copy Markdown
Member

Fixed/changed base branch to 4.11, I'll merge this thanks @rafaelweingartner

@yadvr
yadvr merged commit 9288c64 into apache:4.11 Apr 19, 2018
@blueorangutan

Copy link
Copy Markdown

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✖centos7 ✖debian. JID-1959

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants