Use double quotes with 'RROUTER' variable in "common.sh" script - #2586
Merged
Conversation
|
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1954 |
yadvr
approved these changes
Apr 19, 2018
|
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
|
Fixed/changed base branch to 4.11, I'll merge this thanks @rafaelweingartner |
|
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✖centos7 ✖debian. JID-1959 |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1960 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While debugging the VR for #2579, I noticed that one of the scripts were breaking. The variable
RROUTERwas not set and this broke a conditional.Types of changes
How Has This Been Tested?
Locally
Checklist:
Testing
@blueorangutan package