CLOUDSTACK-9904: Fix log4j to have @AGENTLOG@ replaced - #2070
Merged
Conversation
Member
Author
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-685 |
Contributor
|
@rhtyd Can we create a jira issue for this? |
Member
Author
yadvr
changed the title
yadvr
changed the title
This fixes log4j xml to have @agentlog@ replaced with values defined in build/replace.properties. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-695 |
kiwiflyer
self-requested a review
May 12, 2017 12:43
kiwiflyer
approved these changes
May 12, 2017
Member
|
code changes LGTM. |
karuturi
added
status:waiting-for-author
and removed
status:waiting-for-reviewer
labels
Member
Author
|
Sure @karuturi I'll kicked it again, the issue was an intermittent failure unrelated to this PR |
yadvr
added
status:CI-running
status:waiting-for-reviewer
and removed
status:waiting-for-author
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes log4j xml to have @agentlog@ replaced with values defined
in build/replace.properties.
Without the fix, spurious log files with names such as @agentlog@ are seen.